src: validate stdio entries in process_wrap#61978
Open
dhruv7539 wants to merge 3 commits intonodejs:mainfrom
Open
src: validate stdio entries in process_wrap#61978dhruv7539 wants to merge 3 commits intonodejs:mainfrom
dhruv7539 wants to merge 3 commits intonodejs:mainfrom
Conversation
nodejs-github-bot
added
c++
addaleax
approved these changes
Feb 25, 2026
addaleax
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Author
|
Follow-up fix pushed in 9aa1a1d: the new test regex was over-escaped (matching literal backslashes), which caused the CI failure. Could a collaborator please add the request-ci label to retrigger Jenkins for this commit? |
addaleax
approved these changes
Feb 25, 2026
addaleax
added
request-ci
Member
|
@dhruv7539 The linter is failing here anyway, that should be addressed first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61978 +/- ##
==========================================
- Coverage 89.77% 89.75% -0.02%
==========================================
Files 674 674
Lines 205670 205709 +39
Branches 39426 39442 +16
==========================================
+ Hits 184635 184641 +6
- Misses 13272 13316 +44
+ Partials 7763 7752 -11
🚀 New features to boost your workflow:
|
Author
|
Pushed follow-up commit bdb66fb to fix the clang-format failure in src/process_wrap.cc. Could a collaborator please add the request-ci label so Jenkins runs on this latest commit? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This guards ProcessWrap::ParseStdioOptions() against non-object entries in options.stdio.
Before this change, each options.stdio[i] value was cast directly with val.As(). If Array.prototype is polluted (for example with a setter at index 2), child_process.spawn() can hit a fatal abort (FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal) instead of throwing a JS error.
This patch:
Refs: #56531